Use authenticated requests on the cluster #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasks/helpers/okapi.rb
Outdated
| @@ -7,11 +7,11 @@ module OkapiTaskHelpers | |||
| include FolioRequestHelper | |||
|
|
|||
| def timers_get | |||
| JSON.parse(@@folio_request.unauthenticated_request('/_/proxy/tenants/sul/timers')) | |||
| JSON.parse(@@folio_request.authenticated_request('/_/proxy/tenants/sul/timers')) | |||
There was a problem hiding this comment.
Can we pair on this? We don't have to be authenticated in order to run this within the cluster. Doing curl $OKAPI_URL/_/proxy/tenants/sul/timers from the folio-k8s-pod returns data.
There was a problem hiding this comment.
So I can change it to @@folio_request.request('/_/proxy/tenants/sul/timers') and that should work as well.
shelleydoljack
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One last small PR. When run on the cluster we need to use authenticated requests.