Defer non-critical CSS without changing cascade order #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 9254fbf, we deferred non-critical CSS by loading it at the end of the page. However, this had an unintended side-effect: making the viewer CSS load last in the cascade. This meant that fixes like geoblacklight/geoblacklight@12bd71f had no effect, because they were loaded as part of geoblacklight's CSS and then overridden by the viewer's own CSS. This change switches to the strategy outlined in https://web.dev/articles/defer-non-critical-css, which defers CSS loading but reverts to the original DOM order for the styles, preserving the ability to affect Leaflet's styles in our own without resorting to !important. It also removes one instance where we were using !important to get around this problem.
hudajkhan
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 9254fbf, we deferred non-critical CSS by loading it at the
end of the page. However, this had an unintended side-effect:
making the viewer CSS load last in the cascade.
This meant that fixes like geoblacklight/geoblacklight@12bd71f
had no effect, because they were loaded as part of geoblacklight's
CSS and then overridden by the viewer's own CSS.
This change switches to the strategy outlined in
https://web.dev/articles/defer-non-critical-css,
which defers CSS loading but reverts to the original DOM order
for the styles, preserving the ability to affect Leaflet's
styles in our own without resorting to !important.
It also removes one instance where we were using !important
to get around this problem.