Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-expanded from location accordion #4112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove aria-expanded from location accordion #4112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/catalog/_accordion_section_library.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<%= snippet %>
</span>
</div>
<div class="details <%= id %>-location" aria-expanded="false" data-controller="live-lookup" data-live-lookup-url-value="<%= availability_index_path %>">
<div class="details <%= id %>-location" data-controller="live-lookup" data-live-lookup-url-value="<%= availability_index_path %>">
<% if document.holdings.present? %>
<% document.holdings.libraries.select(&:present?).each do |library| %>
<%= render SearchResult::LocationComponent.new(library:, document:) %>
Expand Down
2 changes: 1 addition & 1 deletion spec/views/catalog/_accordion_section_library.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
expect(rendered).to have_css('.accordion-section.location')
expect(rendered).to have_css('.accordion-section.location button.header[aria-expanded="false"]', text: "Check availability")
expect(rendered).to have_css('.accordion-section.location span.snippet', text: "Green Library")
expect(rendered).to have_css('.accordion-section .details[aria-expanded="false"]')
expect(rendered).to have_css('.accordion-section .details')
expect(rendered).to have_css('.accordion-section .details tbody tr', count: 2)
expect(rendered).to have_css('.accordion-section .details tbody tr th', text: /Stacks/)
expect(rendered).to have_css('.accordion-section .details tbody tr td', text: /ABC 123/)
Expand Down