Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom DBC attributes #19

Merged
merged 6 commits into from
Mar 2, 2023
Merged

feat: add custom DBC attributes #19

merged 6 commits into from
Mar 2, 2023

Conversation

t-bre
Copy link
Member

@t-bre t-bre commented Mar 2, 2023

Changes

  • Custom DBC attributes to enable/disable telemetry and define PDU IDs.
  • Constant defining CAN handler table size for on-car telemetry.
  • PDU identifiers based on custom DBC attribute values now added to CAN handler table.

Related Issue(s)

Closes #8
Closes #16
Closes #18

Additional Notes

Now possible to do #13, we will just need to decide on the prioritisation.

@t-bre t-bre self-assigned this Mar 2, 2023
@t-bre t-bre added the feature New feature or request label Mar 2, 2023
@t-bre t-bre added this to the STAG 9 milestone Mar 2, 2023
@t-bre t-bre requested a review from rureverek March 2, 2023 14:47
@t-bre t-bre marked this pull request as ready for review March 2, 2023 14:52
@t-bre
Copy link
Member Author

t-bre commented Mar 2, 2023

@AndreasDemenagas does it matter how the PDUs are sorted in the server schemas? The current code doesn't necessarily put them in increasing PDU ID order, though perhaps this would be easier to read if looking at the schema?

Copy link
Contributor

@rureverek rureverek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@t-bre t-bre merged commit 5ddadab into main Mar 2, 2023
@t-bre t-bre deleted the feat/custom-dbc-attributes branch March 2, 2023 15:14
@t-bre t-bre mentioned this pull request Mar 2, 2023
3 tasks
@AndreasDemenagas
Copy link

@AndreasDemenagas does it matter how the PDUs are sorted in the server schemas? The current code doesn't necessarily put them in increasing PDU ID order, though perhaps this would be easier to read if looking at the schema?

@t-bre No, it does not. The first PDUs in the schema file are the first ones to be shown in the GUI, but this can be changed and we can add our own ordering with just some custom properties on the schema :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
3 participants