-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom DBC attributes #19
Conversation
@AndreasDemenagas does it matter how the PDUs are sorted in the server schemas? The current code doesn't necessarily put them in increasing PDU ID order, though perhaps this would be easier to read if looking at the schema? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK.
@t-bre No, it does not. The first PDUs in the schema file are the first ones to be shown in the GUI, but this can be changed and we can add our own ordering with just some custom properties on the schema :) |
Changes
Related Issue(s)
Closes #8
Closes #16
Closes #18
Additional Notes
Now possible to do #13, we will just need to decide on the prioritisation.