Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort PDUs by CAN message priority #14

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

t-bre
Copy link
Member

@t-bre t-bre commented Feb 7, 2023

Changes

  • PDUs in the intermediate server schema are sorted by priority of the corresponding CAN message. Smaller number PDUs (higher priority in the telemetry protocol) correspond to smaller CAN ID values (higher priority in CAN).
  • This is an initial implementation for feat: prioritise PDUs #13, but it could be improved by allowing us to specify our own priority through a custom DBC attribute (depends on feat: custom DBC attributes  #8 being solved first).

Additional Notes

Will create release v0.0.5 from this after review.

@t-bre t-bre added the feature New feature or request label Feb 7, 2023
@t-bre t-bre added this to the STAG 9 milestone Feb 7, 2023
@t-bre t-bre self-assigned this Feb 7, 2023
@t-bre
Copy link
Member Author

t-bre commented Feb 7, 2023

@rureverek For info, we should think about how or if on-car telemetry will implement some kind of priority system for transmitting PDUs. Not sure what this would look like, but something to think about.

Copy link

@AndreasDemenagas AndreasDemenagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@AndreasDemenagas AndreasDemenagas merged commit a4b16a6 into main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants