Image import: Make Exif handling more tolerant, better info,... #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the "Add pictures to dive" function: - Make Exif handling more tolerant by removing the JPG sanity check for EOI - Give info to user if exif.cpp can't identify a Exif date/time - Restrict file dialog filter for correct picture time by DC photo to JPG because Exif is only available from JPG Signed-off-by: Stefan Fuchs <[email protected]>
|
@sfuchs79, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dirkhh, @tcanabrava and @atdotde to be potential reviewers. |
|
How about adding a test case that ensures one of your nok images is parsed properly. I am quite sure, we are going to update the exif.cpp from upstream at some point, and it would be nice to notice the breakage immediately if the upstream has not taken the trailer in JPEGs into account at that time. Of course, this makes sense only if Dirk is willing to take this patch :) |
Merged
|
@atdotde added s.th. nice on top of this and created a new PR -> pull Roberts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the moment the most lightweigth fix for #370 and it is imho even good enought to keep it for a long time until s.o. want's to improve this further. This statement is for sure based on my assumption that most users will have JPG pictures. For TIFF with Exif info this for sure doesn't realy improve the situation but it also doesn't make it worse.
Regarding the exif.cpp change: A think the sanity check for the JPG EOI has no added value because later in the processing there is also the check for correct Exif data.