Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Revise list of default types #4118

Merged
merged 5 commits into from
Dec 23, 2024
Merged

[Rust] Revise list of default types #4118

merged 5 commits into from
Dec 23, 2024
+72 −3

Conversation

FichteFoll
Copy link
Collaborator

  • Move patterns to variables.
  • Split types (struct, enum) vs traits vs enum instances.
  • Add missing types from 2021 prelude.
  • Add more commonly used types and traits of the std lib (which are maintained in separate variables).

@FichteFoll
[Rust] Add some common std types
be2caef 
VecDeque, BTreeSet, HashSet
@FichteFoll
[Rust] Move std types and traits to variables
03b7df9
@FichteFoll
[Rust] Somewhat sort std types & traits
dd9e855 
Some items were duplicated, not in the correct set and single lines are
generally hard to edit.

Try to establish a categorization into related types and traits without
thinking too much about it.
@FichteFoll
[Rust] Rename std_{types,traits} to prelude_*
7cd2a86 
Reorganizing them in the process based on the modules they are defined
in.

Also split off enum names into a separate variable, although I don't
have a scope idea for them now.

Adds FromIterator, TryFrom, TryInto from the 2021 prelude.

Adds multiple types of std::sync and std::ops because they are used
frequently.
@FichteFoll FichteFoll changed the title Revise list of default types [Rust] Revise list of default types Dec 23, 2024
@FichteFoll FichteFoll merged commit be1bdd1 into sublimehq:master Dec 23, 2024
1 check passed
@FichteFoll FichteFoll deleted the pr/rust/std-types branch December 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfcherng jfcherng jfcherng approved these changes

@michaelblyons michaelblyons michaelblyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FichteFoll @michaelblyons @jfcherng