-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] jBAY and BAY vortex generator model #2273
base: develop
Are you sure you want to change the base?
Conversation
Added configuartion options for enabling the model, calibration constant and filename for configuring the VG geometry.
Added function to read the vg.conf file Added definition and initialization of VG object.
Implemented functions in Solver to preprocess source term and call from CDriver.
Hi, Can you bring the external packages in your PR up to date? You probably missed a 'git submodule update --init' or something similar. |
Thank you, should be updated now. |
d94de4e
to
e242d82
Compare
e242d82
to
7edc68b
Compare
The source term is pretty simple but the feature as a whole is very intrusive on the code, even the mesh deformation is getting involved in this. |
Proposed Changes
The current work implements the BAY and jBAY vortex generator source-term model using a jBAY cell selection method in the compressible and incompressible solver. The model allows to simulate triangular and rectangular vortex generators. The model is based of https://doi.org/10.4233/uuid:704d764a-6803-4cad-991f-45dc4ea38f6d.
PR Checklist
pre-commit run --all
to format old commits.