Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] jBAY and BAY vortex generator model #2273

Draft
wants to merge 115 commits into
base: develop
Choose a base branch
from

Conversation

maxi120
Copy link

@maxi120 maxi120 commented Apr 27, 2024

Proposed Changes

The current work implements the BAY and jBAY vortex generator source-term model using a jBAY cell selection method in the compressible and incompressible solver. The model allows to simulate triangular and rectangular vortex generators. The model is based of https://doi.org/10.4233/uuid:704d764a-6803-4cad-991f-45dc4ea38f6d.

PR Checklist

  • [ x ] I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • [ x ] I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Added configuartion options for enabling the model, calibration constant and filename for configuring the VG geometry.
Added function to read the vg.conf file
Added definition and initialization of VG object.
Implemented functions in Solver to preprocess source term and call from CDriver.
@bigfooted
Copy link
Contributor

Hi, Can you bring the external packages in your PR up to date? You probably missed a 'git submodule update --init' or something similar.

@maxi120
Copy link
Author

maxi120 commented Apr 29, 2024

Hi, Can you bring the external packages in your PR up to date? You probably missed a 'git submodule update --init' or something similar.

Thank you, should be updated now.

@maxi120 maxi120 force-pushed the feature_VGBAYModel branch from d94de4e to e242d82 Compare April 29, 2024 17:06
@maxi120 maxi120 force-pushed the feature_VGBAYModel branch from e242d82 to 7edc68b Compare April 29, 2024 17:10
@pcarruscag
Copy link
Member

pcarruscag commented May 7, 2024

The source term is pretty simple but the feature as a whole is very intrusive on the code, even the mesh deformation is getting involved in this.
Would it be viable to use the python wrapper to provide the source term?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants