-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix volume names #2079
base: develop
Are you sure you want to change the base?
[WIP] fix volume names #2079
Conversation
There are some other find_last_of lines as well, if all filenames are supposed to be given without any file extension, then these should all be removed. |
In principle sounds good, it will probably break lots of cases, optimization scripts and what not. We'll see, we are not leaving this inconsistent though, all or nothing. |
I agree. |
Proposed Changes
For volume names, we assume that the filename is filename.ext and we strip the extension using find_last_of('.')
But:
I think we should simply remove the find_last_of lines. There are more of those, for now I have simply removed the one connected to #2074
Related Work
Issue: #2074
PR Checklist