Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update article page style for better readability #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anivanchen
Copy link
Member

@anivanchen anivanchen commented Dec 22, 2023

The page felt really packed which impacted both the readability (at the very least the ease of) of the article and the aesthetic look of the page.

Before

Screenshot 2023-12-22 at 10 28 09 AM

After

Screenshot 2023-12-22 at 10 27 49 AM

@anivanchen anivanchen requested a review from leomet07 December 22, 2023 15:32
@leomet07
Copy link
Member

Thanks for the PR Ivan (@anivanchen )!
Honestly I really dig the less-cramped vibe you added.
I'll probably still end up setting the article max-width to something a bit bigger, like 850px. But other than that, I'll just merge this :)

Thanks once again!

@anivanchen
Copy link
Member Author

@leomet07 I was playing around with the max-width of the article and thought that the max-width being too large was contributing to the cramped feeling of the page so I lowered it to what looked right and found around 720px was a good balance.

You can probably also put ads on the side of the screen on desktop or short staff descriptions in the side margins to fill the space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants