Fix concurrent assertions #4426
Open
+135
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The server enforces that the counter attached to the assertion increases with each assertion. This means if one client happens to attempt to send multiple assertions at once, and the network requests arrive out of order, we'll fail the assertion.
To work around this, we'll change the API so that the
StripeAttestreturns anAssertionHandle. It's required to callcomplete()with this handle, or no future assertions will proceed.I'm also going to make
stripeAttesta parameter of an STPAPIClient — now that there's more state involved, it makes more sense for an STPAPIClient to own this instead of creating one each time.Testing
CI, added a new test, tested attestation on device.