Introduce IntegrationConfigurable #4081
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -244,7 +244,7 @@ class CustomerAddPaymentMethodViewController: UIViewController { | |
| isSettingUp: true, | ||
| countryCode: nil, | ||
| savePaymentMethodConsentBehavior: savePaymentMethodConsentBehavior, | ||
| analyticsHelper: .init(isCustom: false, configuration: PaymentSheet.Configuration.init()) // Just use a dummy analytics helper; we don't look at these analytics. | ||
|
There was a problem hiding this comment. Can you add https://jira.corp.stripe.com/browse/MOBILESDK-2548 to this comment |
||
| ).make() | ||
| formElement.delegate = self | ||
| return formElement | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| // | ||
| // IntegrationConfigurable.swift | ||
| // StripePaymentSheet | ||
| // | ||
| // Created by Nick Porter on 10/1/24. | ||
| // | ||
|
|
||
| import Foundation | ||
| import UIKit | ||
| @_spi(STP) import StripePayments | ||
|
|
||
| /// Represents shared configuration properties shared between integration surfaces in mobile payment element. | ||
| /// - Note: See the concrete implementations of `IntegrationConfigurable` for detailed doc comments. | ||
| /// - Note: Not currently used by CustomerSheet. | ||
| protocol IntegrationConfigurable: PaymentMethodRequirementProvider { | ||
|
There was a problem hiding this comment. Open to naming suggestions There was a problem hiding this comment. Let's call it PaymentElementConfiguration? I think that's the most accurate name, since this is Configuration for all Mobile Payment Element integration variants. We just need to start thinking of PaymentSheet, FlowController, EmbeddedPaymentElement as Payment Element variants. There was a problem hiding this comment. This means we should probably rename things like There was a problem hiding this comment. Agree on renaming other PaymentSheet prefixed classes, maybe something we should tackle when we rename the module. |
||
| var allowsDelayedPaymentMethods: Bool { get set } | ||
| var allowsPaymentMethodsRequiringShippingAddress: Bool { get set } | ||
| var apiClient: STPAPIClient { get set } | ||
| var applePay: PaymentSheet.ApplePayConfiguration? { get set } | ||
| var primaryButtonColor: UIColor? { get set } | ||
| var primaryButtonLabel: String? { get set } | ||
| var style: PaymentSheet.UserInterfaceStyle { get set } | ||
| var customer: PaymentSheet.CustomerConfiguration? { get set } | ||
| var merchantDisplayName: String { get set } | ||
| var returnURL: String? { get set } | ||
| var defaultBillingDetails: PaymentSheet.BillingDetails { get set } | ||
| var savePaymentMethodOptInBehavior: PaymentSheet.SavePaymentMethodOptInBehavior { get set } | ||
| var appearance: PaymentSheet.Appearance { get set } | ||
| var shippingDetails: () -> AddressViewController.AddressDetails? { get set } | ||
| var preferredNetworks: [STPCardBrand]? { get set } | ||
| var userOverrideCountry: String? { get set } | ||
| var billingDetailsCollectionConfiguration: PaymentSheet.BillingDetailsCollectionConfiguration { get set } | ||
| var removeSavedPaymentMethodMessage: String? { get set } | ||
| var externalPaymentMethodConfiguration: PaymentSheet.ExternalPaymentMethodConfiguration? { get set } | ||
| var paymentMethodOrder: [String]? { get set } | ||
| var allowsRemovalOfLastSavedPaymentMethod: Bool { get set } | ||
| var analyticPayload: [String: Any] { get } | ||
| } | ||
|
|
||
| extension IntegrationConfigurable { | ||
|
|
||
| /// Returns `true` if the merchant requires the collection of _any_ billing detail fields - name, phone, email, address. | ||
| func requiresBillingDetailCollection() -> Bool { | ||
| return billingDetailsCollectionConfiguration.name == .always | ||
| || billingDetailsCollectionConfiguration.phone == .always | ||
| || billingDetailsCollectionConfiguration.email == .always | ||
| || billingDetailsCollectionConfiguration.address == .full | ||
| } | ||
|
|
||
| var fulfilledRequirements: [PaymentMethodTypeRequirement] { | ||
| var reqs = [PaymentMethodTypeRequirement]() | ||
| if returnURL != nil { reqs.append(.returnURL) } | ||
| if allowsDelayedPaymentMethods { reqs.append(.userSupportsDelayedPaymentMethods) } | ||
| if allowsPaymentMethodsRequiringShippingAddress { reqs.append(.shippingAddress) } | ||
| if FinancialConnectionsSDKAvailability.isFinancialConnectionsSDKAvailable { | ||
| reqs.append(.financialConnectionsSDK) | ||
| } | ||
| return reqs | ||
| } | ||
| } | ||
|
|
||
| extension PaymentSheet.Configuration: IntegrationConfigurable {} | ||
| extension EmbeddedPaymentElement.Configuration: IntegrationConfigurable {} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should keep this
PaymentSheet.Configuration? I'm not sure this class can reasonably also handle analytics for EMPEThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looking at the class more, it'll be pretty hard. We'll want some embedded specific one.