[BANKCON-14531] Update Instant Debits flow to call /share endpoint for Panther payments
#4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-stripe
commented
Sep 26, 2024
| with closure: @escaping (Value) throws -> T | ||
| ) -> Future<T> { | ||
| chained { value in | ||
| chained(on: queue) { value in |
There was a problem hiding this comment.
Drive-by cleanup of this recently merged method!
mats-stripe
commented
Sep 26, 2024
Comment on lines
+958
to
+966
| let parameters: [String: Any] = [ | ||
| "request_surface": requestSurface, | ||
| "id": paymentDetailsId, | ||
| "credentials": [ | ||
| "consumer_session_client_secret": consumerSessionClientSecret | ||
| ], | ||
| "expected_payment_method_type": expectedPaymentMethodType, | ||
| "expand": ["payment_method"], | ||
| ] |
There was a problem hiding this comment.
mats-stripe
commented
Sep 26, 2024
| consumerSessionClientSecret: consumerSession.clientSecret, | ||
| paymentDetailsId: paymentDetails.redactedPaymentDetails.id | ||
| ) | ||
| .transformed { $0 as PaymentMethodIDProvider } |
There was a problem hiding this comment.
This is where we get to use that new type-erasure API!
tillh-stripe
approved these changes
Sep 26, 2024
mats-stripe
force-pushed
the
mats/call_share_endpoint_for_panther_payments
branch
from
cf977bb to
6440512
Compare
|
🚨 New dead code detected in this PR: {
"FinancialConnectionsAPIClient.swift_sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:)": "FinancialConnectionsAPIClient.swift: warning: sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:) is unused",
"EmptyFinancialConnectionsAPIClient.swift_sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:)": "EmptyFinancialConnectionsAPIClient.swift: warning: sharePaymentDetails(consumerSessionClientSecret:paymentDetailsId:expectedPaymentMethodType:) is unused"
}Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
mats-stripe
deleted the
mats/call_share_endpoint_for_panther_payments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android equivalent: stripe/stripe-android#9308
Summary
This updates the Instant Debits flow to call the
/consumers/payment_details/shareendpoint instead of the/payment_methodsendpoint for Panther payments. This endpoint, along with theexpected_payment_method_type: "card"parameter will indicate whether or not we should "Panther-ize" the payment method response. Lots more details in the Panther eng plan!Motivation
BANKCON-14531
Testing
With some minor changes to the mobile payment elements (PR coming next!) we can now see the full e2e flow in action!
Screen.Recording.2024-09-26.at.3.11.43.PM.mov
Changelog
N/a