[WIP] [Connect] Add logout() #4055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| XCTAssertEqual( | ||
| LogoutSender().javascriptMessage, | ||
| """ | ||
| window.logout({}); |
There was a problem hiding this comment.
Ideally this would be empty args, but there's no easy way to do that with the MessageSender. I tested that sending extra arguments to this function doesn't seem to have any negative effect in JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
logout()call to EmbeddedComponentManagerIn order to ensure that logout works, even when no components have been created, a webview is instantiated in the background so we can call
window.logout()to clear cookies and make a call to the logout endpoint.Motivation
https://jira.corp.stripe.com/browse/MXMOBILE-2488
Testing