Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary action color #4040

Closed
wants to merge 15 commits into from
Closed

Conversation

joyceqin-stripe
Copy link
Collaborator

Summary

Added secondary action color customization

Motivation

https://docs.google.com/document/d/10LYHqMBO_oBAhL3x_auVMZJqMs9wQTOB2kSAM4sOcY8/edit?usp=sharing

Testing

Snapshot tests, test playground
Screenshot 2024-09-23 at 10 05 15 AM
Screenshot 2024-09-23 at 10 05 34 AM
Screenshot 2024-09-23 at 10 06 01 AM

Changelog

@joyceqin-stripe joyceqin-stripe requested review from a team as code owners September 23, 2024 17:33
@joyceqin-stripe joyceqin-stripe changed the title Joyceqin mobilesdk 2488 Secondary action color Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

⚠️ Public API changes detected:

StripePaymentSheet

+ public var secondary: UIKit.UIColor?

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@joyceqin-stripe joyceqin-stripe marked this pull request as draft September 23, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant