Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email verification features #95

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

jcass77
Copy link
Contributor

@jcass77 jcass77 commented Feb 8, 2017

This PR adds the missing email verification handling features. It also adds the 'welcome' page functionality .

There is one test to ensure that the user is redirected to the verification page if they attempt to log in with an unverified account.

Fixes #45.

@rdegges
Copy link
Contributor

rdegges commented Feb 8, 2017

Would you mind merging develop into this and fixing the merge conflicts? It looks like some of your other (great) PRs are conflicting here.

…mail_features

# Conflicts:
#	flask_stormpath/views.py
@jcass77
Copy link
Contributor Author

jcass77 commented Feb 9, 2017

Pushed 19f61a5, with changes from 'develop' merged in.

@jcass77
Copy link
Contributor Author

jcass77 commented Feb 10, 2017

According to the Stormpath specification:

If the error is created by the framework integration (it is not from the REST API), then use status 400 and a human-friendly message string.

I've pushed ab2e0d6, which does just that, if the user tries to use an old outdated verification token.

@jcass77
Copy link
Contributor Author

jcass77 commented Feb 14, 2017

@rdegges, anything else that you would like to see addressed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants