Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wallet nicknames #7

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Support wallet nicknames #7

merged 1 commit into from
Feb 21, 2024

Conversation

jtolio
Copy link
Member

@jtolio jtolio commented Feb 20, 2024

The idea here is you can configure briskitall with a set of named wallets, like "multisig:0x123,bill:0x456,fred:0x789" and then get those names in your output. As long as you trust your config, this makes it so it's visually easier to evaluate if what you want to sign is correct.

@jtolio jtolio requested a review from azdagron February 20, 2024 23:03
params.go Outdated
func transformNicknameMap(s string) (multisig.NicknameMap, error) {
nicknames := multisig.NicknameMap{}
for _, definition := range strings.Split(s, ",") {
parts := strings.Split(definition, ":")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see strings.Cut

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@jtolio jtolio merged commit 251f649 into main Feb 21, 2024
1 check passed
@jtolio jtolio deleted the jt-nicknames branch February 21, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants