Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show event dates in transaction status output #6

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Conversation

jtolio
Copy link
Member

@jtolio jtolio commented Feb 20, 2024

This change is useful so you can know how stale an event is.

@jtolio jtolio requested a review from azdagron February 20, 2024 22:10
- ETH[0]: Submission()
- ETH[1]: Confirmation(%s)
- ETH[1]: Execution()
- %s: ETH[0]: Confirmation(%s)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be potentially flaky when the date changes.

@azdagron azdagron merged commit 03f764e into main Feb 21, 2024
1 check passed
@azdagron azdagron deleted the jt-event-timestamp branch February 21, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants