Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue 1080 #1081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

guazhangRH
Copy link
Contributor

No description provided.

@vojtechtrefny vojtechtrefny requested a review from tbzatek December 2, 2024 11:41
Copy link
Member

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not against merging this, but it feels like something that should be fixed in the code, not in tests. But I don't know enough about NVMe so I'll leave the decision on @tbzatek

Copy link
Member

@tbzatek tbzatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to avoid using sleep for things where we can poll for something. In this case you may want to wait for specific subsystem nqn to appear in the list with certain timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants