-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop python<=3.7 support #1218
base: 3.10-devel
Are you sure you want to change the base?
drop python<=3.7 support #1218
Conversation
Fileter all code over `pyupgrade --py38-plus`. Signed-off-by: Tomasz Kłoczko <[email protected]>
Mark that code of this module is only for python>=3.8. Signed-off-by: Tomasz Kłoczko <[email protected]>
Can one of the admins verify this patch? |
Jenkins, ok to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this looks OK to me in general. I don't see a reason for dropping the <= 3.7 support, but I also don't see a reason for not doing that, so if it's going to help you (or someone else) we can merge this. But please fix the pep8/pycodestyle failures. Also the translation-canary
folder is a git subtree so the changes to it should be separate and go through https://github.com/rhinstaller/translation-canary
IIRC fc38 uses python 3.10 or 3.11 so with current CI definition it is not possible to test this module with python<=3.9. In other words it is nothing more than just cutting some legacy tail 😋 |
Asi I said, I am not against doing this, but currently the tests are failing (static analysis is complaining about indentation) so if you want this merged, please fix the failures first. |
Is it any problem with merge this PR an add indentation fixes? |
Filter all python code over
pyuprade --py38-plus
and mark in setup.py that this module is only for python>=3.8.