Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python<=3.7 support #1218

Open
wants to merge 2 commits into
base: 3.10-devel
Choose a base branch
from

Conversation

kloczek
Copy link

@kloczek kloczek commented Mar 28, 2024

Filter all python code over pyuprade --py38-plus and mark in setup.py that this module is only for python>=3.8.

kloczek added 2 commits March 28, 2024 15:58
Fileter all code over `pyupgrade --py38-plus`.

Signed-off-by: Tomasz Kłoczko <[email protected]>
Mark that code of this module is only for python>=3.8.

Signed-off-by: Tomasz Kłoczko <[email protected]>
@StorageGhoul
Copy link

Can one of the admins verify this patch?

@vojtechtrefny
Copy link
Member

Jenkins, ok to test.

Copy link
Member

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this looks OK to me in general. I don't see a reason for dropping the <= 3.7 support, but I also don't see a reason for not doing that, so if it's going to help you (or someone else) we can merge this. But please fix the pep8/pycodestyle failures. Also the translation-canary folder is a git subtree so the changes to it should be separate and go through https://github.com/rhinstaller/translation-canary

@kloczek
Copy link
Author

kloczek commented Apr 3, 2024

I don't see a reason for dropping the <= 3.7 support

blivet module is used by blivet-gui.
At the moment it is not possible to build full GUI desktop without at least python 3.10 (mesa, some parts of gnome during build and rust rpm base tooling needs python>=3.10).

IIRC fc38 uses python 3.10 or 3.11 so with current CI definition it is not possible to test this module with python<=3.9.

In other words it is nothing more than just cutting some legacy tail 😋

@vojtechtrefny
Copy link
Member

In other words it is nothing more than just cutting some legacy tail

Asi I said, I am not against doing this, but currently the tests are failing (static analysis is complaining about indentation) so if you want this merged, please fix the failures first.

@kloczek
Copy link
Author

kloczek commented Apr 22, 2024

Is it any problem with merge this PR an add indentation fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants