-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the TernaryAxis code #11
base: master
Are you sure you want to change the base?
Conversation
This is great! Thanks for the interest. I don't have time to make major changes now, but after mid-March my schedule opens up quite a bit. It is on my list :) |
But feel free to continue this PR, I will catch up with you next month! |
Sounds good! This will be pretty slow burn in any case, as and when I get time for it :) |
OK, so I hacked a bit on this and figured I should change the code first before doing anything else. This relies on Makie master for now but is otherwise just a refactoring of the ternary axis recipe. It brings the ternary axis theme in line with the rest of Makie's axis themes, for later integration as a layoutable (
TODOs:
|
WIP. This aims to build the foundations for a ternary-axis layoutable, which can be directly plotted into.
The PR also has some other minor changes which I needed for my work.
There are 2 potential approaches to implementing this kind of thing:
x + y + z = 1
plane. Then, draw the axis around that.TernaryDiagrams.from_cart_to_bary
). Then, following the method of GeoAxis, change the transform of the ternary axis' plots to this transform.Both approaches will be somewhat technically challenging. Would appreciate any help!