Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SQL for (most) Ledger State #4575

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

SirTyson
Copy link
Contributor

Description

Resolves #4503 and #4502

This change removes SQL support for all ledger state, except for the offers table. It also enforces background eviction. In order to not break Horizon, core will not crash if any of the old flags or config settings are used. Instead it will print a warning and ignore the flags. The flags should be removed in the next protocol release.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

marta-lokhova
marta-lokhova previously approved these changes Dec 16, 2024
Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice to see so much legacy code go away, thank you! I left a few questions wrt the migration, and a couple of minor nits. Otherwise happy to merge this asap.

src/main/Config.cpp Outdated Show resolved Hide resolved
src/main/ApplicationImpl.cpp Show resolved Hide resolved
src/catchup/ApplyBucketsWork.cpp Outdated Show resolved Hide resolved
src/database/Database.cpp Outdated Show resolved Hide resolved
src/main/ApplicationImpl.cpp Outdated Show resolved Hide resolved
src/main/Config.cpp Show resolved Hide resolved
src/main/Config.cpp Show resolved Hide resolved
src/main/PersistentState.h Show resolved Hide resolved
src/database/Database.cpp Show resolved Hide resolved
@marta-lokhova marta-lokhova added this pull request to the merge queue Dec 18, 2024
Merged via the queue into stellar:master with commit b003246 Dec 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Background Eviction Mandatory
2 participants