Cleanup BucketList Access #3957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
requested changes
Oct 5, 2023
There was a problem hiding this comment.
I think for catchup this is a bit trickier, since if the archives were published with the bucketlist enabled, then the local node catching up will fork. I think in this simulation mode, we should not catchup at all. So maybe we should set MODE_DOES_CATCHUP=false if the bucketlist is disabled?
mbsdf
reviewed
Oct 6, 2023
SirTyson
force-pushed
the
bucketlist-asserts
branch
from
a17d157 to
208f932
Compare
SirTyson
force-pushed
the
bucketlist-asserts
branch
from
208f932 to
63adda2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3842
This PR adds additional checks for
MODE_ENABLES_BUCKETLIST. I don't think it is actually possible to access some of the modified code paths whenMODE_ENABLES_BUCKETLIST == false, but I wanted to stay on the safe side since changes later on could cause these asserts to hit.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)