Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an increment example which can be paused by a dependency #342

Merged
merged 16 commits into from
Dec 27, 2024

Conversation

leighmcculloch
Copy link
Member

What

Add an increment example which can be paused by a dependency

Why

For use in examples I'm working on for a blog post and how-to guides on testing.

Testing with dependencies is a topic that needs covering, and a dependency that controls whether a contract is paused is a simple way to introduce a dependency without needing to focus on the dependencies logic and behavior too much.

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure i'm totally qualified to review all of this PR lol. It looks good from what i can tell, though. Follows the testing guides you've written nicely. Thanks a bunch!!

@leighmcculloch leighmcculloch marked this pull request as ready for review December 20, 2024 21:11
@tomerweller tomerweller merged commit aeae367 into main Dec 27, 2024
100 of 103 checks passed
@tomerweller tomerweller deleted the increment-with-pause branch December 27, 2024 02:35
@tomerweller
Copy link
Contributor

tomerweller commented Dec 27, 2024

I disabled status checks on main in order to merge this PR and then re-enabled them. The docs linking to this example have already been merged so the docs were effectively broken. PTAL at the errors when you're back online @leighmcculloch @ElliotFriend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants