Allow --enable-horizon-captive-core on pubnet, testnet #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for enabling captive-core for horizon on pubnet, testnet by removing the code gating it use on those networks and adding appropriate configuration.
Why
I'm looking into how to add the ability to start a local network forked from a remote network. In the process I tried to simplify the number of ways Horizon can run, because I thought it would simplify the steps the quickstart image needs to take when navigating the remote and local network. However, in the end I don't think I'll need this for that work because I've found an approach that doesn't change at all how Horizon will run in this workflow.
In any event, I see #467 is open and according to @ire-and-curses the only reason we haven't done this is because it hasn't been a priority. So opening this change in any case.
Close #467
Merging
This change is intended to be merged to
masterafter #484.