Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dtslint to repo #1094

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add dtslint to repo #1094

wants to merge 5 commits into from

Conversation

ShantelPeters
Copy link

resolves #649

@ShantelPeters
Copy link
Author

@chadoh @BlaineHeffron and @Shaptic
Please kindly review 🙏🏼

Shaptic
Shaptic reviewed Nov 27, 2024
View reviewed changes
config/.eslintrc.js Outdated
// ERROR
'no-unused-expressions': [2, { allowTaggedTemplates: true }]
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC there's something weird about .eslintrc.js existing in the root directory and being picked up by subprograms, bundlers, etc. so I'd prefer if we kept it in there instead of moving it like this. I would say all of config/* needs to get out of that folder (it was a mistake for me to try to consolidate in the first place) but that's a separate issue entirely.

@ShantelPeters
Copy link
Author

Please kindly review @Shaptic

@ShantelPeters
Copy link
Author

@Shaptic
@chadoh kindly review requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Backlog (Not Ready)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Developer feature request: Add dtslint to the toolkit
2 participants
@ShantelPeters @Shaptic