This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial demo script #157
Initial demo script #157
Changes from 1 commit
3b08fc6
9f7d7b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to do this on the receiving end, and have Bob show the transaction. We could have a flow like this:
This way Bob is spending funds on the chain that he didn't have access to before, due to the "offchain" payment. I think that makes the off-chain payment feel more "real", since after Bob receives it he can spend more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. That'd be a good way to show the cross-chain functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Alice has Network1 funds she can sign over to Irene, and Irene has Network2 funds she can sign over to Bob."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to list requirements for off-chains payments to work. Can you rephrase your statement so that it indicates what MUST be done by Alice, Irene, and Bob instead of what COULD be done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alice MUST have sufficient Network1 funds she can sign over to Irene, and Irene MUST have sufficient Network2 funds she can sign over to Bob.
Concretely, if Alice wants to Pay bob
x
coins, Alice-Irene SCW has balance[a,i1]
and Irene-Bob has balance[i2,b]
, then the condition isx<=a
ANDx<=i2*e
, wheree
is the exchange rate from network2 funds to network1 funds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this satisfy what you are saying?
Your formula and associated variables make sense but I think its better to communicate using concise bullet points for the demo so I'm trying to get it into that format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
I would specify that these funds need to be in Bob's wallet. Not just "on Network2"
Otherwise, seems good. I don't know if you need to underline that the intermediary can access both networks. That is probably implied by having funds on each network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I'll remove the bullet about intermediary accessing both network. How about this: