Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixture explicit definition of non-devnet setup #779

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

tabaktoni
Copy link
Collaborator

Motivation and Resolution

Fix #778

  • always use env TEST_ACCOUNT_ADDRESS and TEST_ACCOUNT_PRIVATE_KEY if defined even if it is a local provider
  • added environment parameter LOCAL_DEVNET
    -- If undefined,1,true local devnet setup will be enabled and we will assume localhost or 127.0... is local devnet
    -- if 0,false local devnet setup will be disabled and we assume the user is not running local devnet, consequently need to set TEST_ACCOUNT_ADDRESS and TEST_ACCOUNT_PRIVATE_KEY

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@tabaktoni tabaktoni requested review from ivpavici and penovicp October 4, 2023 15:34
@tabaktoni tabaktoni merged commit 49c72cd into develop Oct 16, 2023
4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 5.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@penovicp penovicp deleted the fix/fixture branch November 13, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run local rpc node like pathfinder issue
3 participants