Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable base fetch override #1279

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: enable base fetch override #1279

merged 1 commit into from
Dec 3, 2024

Conversation

penovicp
Copy link
Collaborator

@penovicp penovicp commented Dec 2, 2024

Motivation and Resolution

Enables a base fetch override for the channel classes and ensures the same fetch is used within the underlying BatchClient. This is the first step of the isomorphic-fetch and fetch-cookie dependency removal.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@penovicp penovicp requested a review from ivpavici December 3, 2024 07:41
@penovicp penovicp merged commit 0fce61e into develop Dec 3, 2024
3 checks passed
@penovicp penovicp deleted the feat/base-fetch branch December 3, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants