docs: Add new topic on migrating from DAI v0 to DAI. #1181

stoobie · 2024-03-14T13:57:42Z

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

Changes have been done against main branch, and PR does not conflict
PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is

github-actions · 2024-03-14T13:59:00Z

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1181/documentation/ .

natan-granit

I left some comments

natan-granit · 2024-03-14T14:10:56Z

components/Starknet/modules/tools/pages/dai_token_migration.adoc

+
+You can withdraw old DAI tokens (DAI v0) without any limitation. Depositing using the DAI v0 bridge are disabled. You are encouraged to migrate to the new DAI token. You can use swap services on Starknet to swap DAI v0 for DAI.
+
+You are encouraged to migrate your old DAI (DAI v0) tokens for new DAI tokens.


Should be deleted, it is repeated

natan-granit · 2024-03-14T14:11:20Z

components/Starknet/modules/tools/pages/dai_token_migration.adoc

+[id="dai_token_migration"]
+= Migrating DAI tokens on Starknet to the new DAI contract
+
+Following link:https://twitter.com/MakerDAO/status/1746977683190251591?s=20


In the preview, the link was not working, it was just there as text

natan-granit · 2024-03-14T14:12:02Z

components/Starknet/modules/tools/nav.adoc

@@ -23,6 +23,7 @@
 **** xref:starkgate-adding_a_token.adoc[Adding a token]
 **** xref:starkgate-cancelling a deposit.adoc[Cancelling a deposit]
 **** xref:starkgate-estimating_fees.adoc[Estimating StarkGate fees]
+**** xref:dai_token_migration.adoc[Migrating DAI tokens on Starknet to the new DAI contract]


Lets change the title to:
DAI Migration

Done. Although I'm not thrilled. This topic the way it was originally written is more of an announcement. If we're adding it to technical documentation, telling people how to migrated, it should really be a procedural heading like other procedural headings that end with "ing".

About the title - I found the one you suggested a bit clumsy. Can you think of a compromise?

How about "Migrating DAI v0 to DAI" for the topic title, and I'll change the procedure heading to "Procedure", like other Procedures?

natan-granit · 2024-03-14T14:13:58Z

components/Starknet/modules/tools/pages/dai_token_migration.adoc

+On January 25th, StarkWare launched a new set of DAI bridge and token contracts under StarkGate, written in Cairo. This new DAI token will retain the same contract ’symbol’ and ’name’ as the existing one. To differentiate between the two on Apps and other UIs, we refer to the old DAI as “DAI v0” and the new DAI simply as “DAI.”
+
+
+== Migrate from v0 Starknet DAI tokens to new Starknet DAI tokens


I would prefer:
Migrate DAI v0 to DAI or Migrate your DAI v0
I don't like to refer to the new DAI as such. It is just DAI. Also, it is not Starknet DAI. It is just DAI. We chose names, I want to use them.

Ok, but I think it would be better to be as specific as possible. The naming you chose might be appropriate for conversations and targeted communications, but this page will show up in search results, and it'll probably generate false positives if we don't specify that it's referring to Starknet. I'll add more details in the :description: metadata.

stoobie

@natan-granit I made several fixes and comments.

stoobie · 2024-03-14T16:12:44Z

components/Starknet/modules/tools/pages/dai_token_migration.adoc

+[id="dai_token_migration"]
+= Migrating DAI tokens on Starknet to the new DAI contract
+
+Following link:https://twitter.com/MakerDAO/status/1746977683190251591?s=20


stoobie · 2024-03-14T16:13:02Z

components/Starknet/modules/tools/pages/dai_token_migration.adoc

+
+You can withdraw old DAI tokens (DAI v0) without any limitation. Depositing using the DAI v0 bridge are disabled. You are encouraged to migrate to the new DAI token. You can use swap services on Starknet to swap DAI v0 for DAI.
+
+You are encouraged to migrate your old DAI (DAI v0) tokens for new DAI tokens.


stoobie · 2024-03-14T16:14:57Z

components/Starknet/modules/tools/pages/dai_token_migration.adoc

+On January 25th, StarkWare launched a new set of DAI bridge and token contracts under StarkGate, written in Cairo. This new DAI token will retain the same contract ’symbol’ and ’name’ as the existing one. To differentiate between the two on Apps and other UIs, we refer to the old DAI as “DAI v0” and the new DAI simply as “DAI.”
+
+
+== Migrate from v0 Starknet DAI tokens to new Starknet DAI tokens


Ok, but I think it would be better to be as specific as possible. The naming you chose might be appropriate for conversations and targeted communications, but this page will show up in search results, and it'll probably generate false positives if we don't specify that it's referring to Starknet. I'll add more details in the :description: metadata.

stoobie · 2024-03-14T16:15:59Z

components/Starknet/modules/tools/pages/dai_token_migration.adoc

+
+StarkGate automatically issues the new DAI.
+
+* Swap your DAI v0 for DAI using an L2 swap app or aggregator within the Starknet ecosystem.


@natan-granit Are there any more details than this? Is there an existing swap app or aggregator that we can point to? Or a page that lists all of them?

There are at least 2 I know of - should we add and be responsible for changing in the future?
LayerSwap - https://www.layerswap.io/migration/DAI
Ekubo - https://app.ekubo.org/?amount=1000&inputCurrency=DAI&outputCurrency=DAIv2

I think that we need to give some guidance. Are there, or do you think there will be, more than these two?

Do you anticipate that these two will change?

Is there a search term that we can suggest to locate apps like this?

github-actions · 2024-03-14T16:19:59Z

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1181/documentation/ .

github-actions · 2024-03-17T12:04:17Z

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1181/documentation/ .

github-actions · 2024-03-17T12:14:25Z

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1181/documentation/ .

natan-granit

LGTM

* Add new topic on migrating from DAI v0 to DAI. * SME comments + meta info * Playing with title * Added Ekubo and Layerswap as sample swap apps

Add new topic on migrating from DAI v0 to DAI.

cf7ca36

stoobie requested a review from natan-granit March 14, 2024 13:57

natan-granit reviewed Mar 14, 2024

View reviewed changes

SME comments + meta info

d13318d

stoobie commented Mar 14, 2024

View reviewed changes

Playing with title

6cc78d0

Added Ekubo and Layerswap as sample swap apps

af69be7

natan-granit approved these changes Mar 17, 2024

View reviewed changes

stoobie merged commit ccfc4aa into main Mar 17, 2024
3 checks passed

stoobie deleted the steve/starkgate/new_DAI branch March 17, 2024 12:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Add new topic on migrating from DAI v0 to DAI. #1181

docs: Add new topic on migrating from DAI v0 to DAI. #1181

stoobie commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024

natan-granit left a comment

natan-granit Mar 14, 2024

stoobie Mar 14, 2024

natan-granit Mar 14, 2024

stoobie Mar 14, 2024

natan-granit Mar 14, 2024

stoobie Mar 14, 2024

natan-granit Mar 17, 2024

stoobie Mar 17, 2024

natan-granit Mar 14, 2024

stoobie Mar 14, 2024

stoobie left a comment

stoobie Mar 14, 2024

stoobie Mar 14, 2024

stoobie Mar 14, 2024

stoobie Mar 14, 2024

natan-granit Mar 17, 2024 •

edited

Loading

stoobie Mar 17, 2024

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 17, 2024

github-actions bot commented Mar 17, 2024

natan-granit left a comment


		You can withdraw old DAI tokens (DAI v0) without any limitation. Depositing using the DAI v0 bridge are disabled. You are encouraged to migrate to the new DAI token. You can use swap services on Starknet to swap DAI v0 for DAI.

		You are encouraged to migrate your old DAI (DAI v0) tokens for new DAI tokens.

		On January 25th, StarkWare launched a new set of DAI bridge and token contracts under StarkGate, written in Cairo. This new DAI token will retain the same contract ’symbol’ and ’name’ as the existing one. To differentiate between the two on Apps and other UIs, we refer to the old DAI as “DAI v0” and the new DAI simply as “DAI.”


		== Migrate from v0 Starknet DAI tokens to new Starknet DAI tokens

docs: Add new topic on migrating from DAI v0 to DAI. #1181

docs: Add new topic on migrating from DAI v0 to DAI. #1181

Conversation

stoobie commented Mar 14, 2024 • edited Loading

Description of the Changes

PR Preview URL

Check List

github-actions bot commented Mar 14, 2024

natan-granit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stoobie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

natan-granit Mar 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 14, 2024

github-actions bot commented Mar 17, 2024

github-actions bot commented Mar 17, 2024

natan-granit left a comment

Choose a reason for hiding this comment

stoobie commented Mar 14, 2024 •

edited

Loading

natan-granit Mar 17, 2024 •

edited

Loading