New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added invariant check for null data values #4

Open

wmyers wants to merge 1 commit into master from add-missing-data-logging

wmyers commented Sep 18, 2017

Why is this change necessary?

If a falsy data prop is passed in to a Radar component then a deep React rendering error occurs.

How does it address the issue?

Adding invariant (for meaningful errors in non-PRODUCTION envs) to log if data is passed with a falsy value.

What side effects does this change have?

None

How was it tested?

Should pass test suite


          added invariant check for null data values

0ecad72

wmyers self-assigned this

wmyers requested a review from adamjcsmith

September 18, 2017 15:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet