Rebase to remove PR #41 #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UDP performance is bad for connection-level subscriptions, due to UDP connections being re-inserted in connection table. - This is one proposed solution: keep UDP connections around in the connection table in a "dropped" state until the timerwheel ages them out. Testing done: - Ran log_quic and log_dns on both live traffic (anon ips) and pcaps - Output on live traffic was reasonable; output on pcaps was correct - Repeated with log_* with connection-level subscriptions (Connection)
Note Retina has now been tested on a non-mlx5 nic.
|
Thank you!
It looks like the source tree is a little bit messed up, since there are still a few conflicts? |
|
Closing this as it was cleaner to fix the merge conflicts locally. Please see PR #58. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes #41 from the git history. Effectively adding the QUIC parsing commits back.
Testing
I ran
loq_quicfor 5 minutes on live traffic:FYI, I'm still seeing a large number of drops for long running (>60s) captures.
@thearossman, can you confirm that this still builds on your ARM boxes? This also includes the commits for your upgraded UDP state, I'm pretty sure nothing is broken but you might want to double check.