cargo fmt

core/src/filter/actions.rs

@@ -11,8 +11,8 @@
 //! Each filter stage returns a set of actions and a set of terminal actions.
 //! The terminal actions are the subset of actions that are maintained through
 //! the next filter stage.
-use std::fmt;
 use bitmask_enum::bitmask;
+use std::fmt;
 
 #[bitmask]
 #[bitmask_config(vec_debug)]

core/src/filter/ast.rs

@@ -75,9 +75,7 @@ fn has_path(from: &ProtocolName, to: &ProtocolName) -> bool {
 #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
 pub enum Predicate {
     /// Matches on a protocol
-    Unary {
-        protocol: ProtocolName,
-    },
+    Unary { protocol: ProtocolName },
     /// Matches on a field in a protocol
     Binary {
         protocol: ProtocolName,

core/src/protocols/stream/conn/mod.rs

@@ -18,6 +18,9 @@ pub(crate) enum ConnDataError {
 }
 
 /// A trait that all extractable ConnData fields must implement
+/// This is used for filtering on L3/L4 fields following the packet
+/// filter stage (i.e., when protocol, port, etc. cannot be extracted
+/// fro a packet).
 pub trait ConnField {
     /// Parse from the ConnData
     fn parse_from(conn: &ConnData) -> Result<Self>

docs/DEVELOPER.md

@@ -1,5 +1,7 @@
 # Retina (v1.0.0) Detailed Developer Documentation
 
+*Work in progress*
+
 This document is intended as a resource for Retina developers and contributors. It is meant to supplement the core [developer documentation](https://stanford-esrg.github.io/retina/retina_core/) and the [original paper](https://zakird.com/papers/retina.pdf). It contains a more detailed and centralized system design description than the documentation. Compared to the original paper, it both reflects more recent changes and inlines links to relevant code.
 
 Retina is in its early stages, and we are actively working on new releases and research that will significantly expand its utility. We welcome contributors and open issues, and we would love to hear about your use-cases (especially if Retina doesn't suit your needs!).