Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for MMLU PRO with COT #3200

Merged
merged 30 commits into from
Dec 6, 2024
Merged

Changes for MMLU PRO with COT #3200

merged 30 commits into from
Dec 6, 2024

Conversation

siyagoel
Copy link
Contributor

@siyagoel siyagoel commented Dec 6, 2024

Final changes to MMLU Pro with COT

when: "?"
language: English

- name: ifeval
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete ifeval

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems identical to chain_of_thought_metric.py - delete this file.

Note: use git rm to delete files in your commit (doc).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file (it is a copy of mmlu_scenario_pro.py)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file. (this is a copy of mmlu_pro_scenario.py

input_prefix="What is the correct answer to this question: ",
input_suffix="\nChoices:\n",
output_prefix="",
reference_prefix="(A) ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this line with reference_prefix (just let AdapterSpec use the default value).

Comment on lines -169 to -172
what: "?"
who: "?"
when: "?"
language: English
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put these back for ifeval

Comment on lines 170 to 171
main_name: ifeval_strict_accuracy
main_name: chain_of_thought_correct # non-CoT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be just main_name: ifeval_strict_accuracy, delete the other line

Copy link
Collaborator

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yifanmai yifanmai merged commit ff9c7c9 into main Dec 6, 2024
12 checks passed
@yifanmai yifanmai deleted the mmlupro_with_cot branch December 6, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants