Merge pull request #627 from detaso/remove-pull-diagnostic

LSP: Don't advertise support for Pull Diagnostics

lib/standard/lsp/routes.rb

@@ -27,10 +27,6 @@ def for(name)
         @writer.write(id: request[:id], result: Proto::Interface::InitializeResult.new(
           capabilities: Proto::Interface::ServerCapabilities.new(
             document_formatting_provider: true,
-            diagnostic_provider: LanguageServer::Protocol::Interface::DiagnosticOptions.new(
-              inter_file_dependencies: false,
-              workspace_diagnostics: false
-            ),
             text_document_sync: Proto::Interface::TextDocumentSyncOptions.new(
               change: Proto::Constant::TextDocumentSyncKind::FULL,
               open_close: true
@@ -51,10 +47,6 @@ def for(name)
         end
       end
 
-      handle "textDocument/diagnostic" do |_request|
-        # no op, diagnostics are handled in textDocument/didChange
-      end
-
       handle "textDocument/didChange" do |request|
         params = request[:params]
         result = diagnostic(params[:textDocument][:uri], params[:contentChanges][0][:text])

test/standard/runners/lsp_test.rb

@@ -17,8 +17,7 @@ def test_server_initializes_and_responds_with_proper_capabilities
       id: 2,
       result: {capabilities: {
         textDocumentSync: {openClose: true, change: 1},
-        documentFormattingProvider: true,
-        diagnosticProvider: {interFileDependencies: false, workspaceDiagnostics: false}
+        documentFormattingProvider: true
       }},
       jsonrpc: "2.0"
     }
@@ -66,21 +65,6 @@ def test_did_open
     }, msgs.first)
   end
 
-  def test_diagnotic_route
-    msgs, err = run_server_on_requests({
-      method: "textDocument/diagnostic",
-      jsonrpc: "2.0",
-      params: {
-        textDocument: {
-          uri: "file:///path/to/file.rb"
-        }
-      }
-    })
-
-    assert_equal "", err.string
-    assert_equal 0, msgs.count
-  end
-
   def test_format
     msgs, err = run_server_on_requests(
       {