Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release2 #843

Merged
merged 3 commits into from
Nov 21, 2023
+5 −5
Merged

Fix release2 #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99839ee
chore: test release
stalniy Nov 21, 2023
4988f12
chore: fix release workflow check
stalniy Nov 21, 2023
1b93ba7
chore: fix release workflow package name extraction
stalniy Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
GH_TOKEN: ${{ secrets.RELEASE_GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.RELEASE_NPM_TOKEN }}
run: |
changed_packages=$(gh pr view --json files --jq '.files.[].path' "${{ github.event.pull_request.number }}" | cut -d / -f 1,2 | uniq)
changed_packages=$(gh pr view --json files --jq '.files.[].path' "${{ github.event.pull_request.number }}" | cut -d / -f 1,2 | uniq | grep ./packages)
pnpm_options=''
for path in $changed_packages; do
pnpm_options="${pnpm_options} --filter ./${path}"
Expand All @@ -53,12 +53,12 @@ jobs:

released_packages=()
for path in $changed_packages; do
package_name=$(grep '"name":' $path | cut -d : -f 2 | cut -d '"' -f 2)
package_version=$(grep '"version":' $path | cut -d : -f 2 | cut -d '"' -f 2)
package_name=$(grep '"name":' $path/package.json | cut -d : -f 2 | cut -d '"' -f 2)
package_version=$(grep '"version":' $path/package.json | cut -d : -f 2 | cut -d '"' -f 2)
released_packages[${#released_packages[@]}]="${package_name}@${package_version}"
done

if [ "${github.event.pull_request.number}" != "" ]; then
if [ "${{github.event.pull_request.number}}" != "" ]; then
gh pr comment "${{ github.event.pull_request.number }}" --body "🚀 Released in ${released_packages[@]}"
fi

Expand Down
2 changes: 1 addition & 1 deletion packages/casl-angular/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This package allows to integrate `@casl/ability` with [Angular] application. It

## Installation

The latest version of this package is compiled by Ivy, so **apps that do not use Ivy are no longer supported.**
The latest version of this package is compiled by Ivy, so **apps that do not use Ivy are no longer supported**.

```sh
npm install @casl/angular @casl/ability
Expand Down
Loading