-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): Add configuration options for the secret migration job #536
Merged
siegfriedweber
merged 2 commits into
main
from
fix_helm/config-options-for-secret-migration-job
Dec 12, 2024
Merged
fix(helm): Add configuration options for the secret migration job #536
siegfriedweber
merged 2 commits into
main
from
fix_helm/config-options-for-secret-migration-job
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siegfriedweber
commented
Dec 11, 2024
deploy/helm/secret-operator/templates/secret_migration_job.yaml
Outdated
Show resolved
Hide resolved
siegfriedweber
commented
Dec 11, 2024
sbernauer
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
siegfriedweber
deleted the
fix_helm/config-options-for-secret-migration-job
branch
December 12, 2024 13:22
siegfriedweber
added a commit
that referenced
this pull request
Dec 13, 2024
* fix(helm): Add configuration options for the secret migration job * fix(helm): Default the tools image to 1.0.0-stackable24.11.0
NickLarsenNZ
pushed a commit
that referenced
this pull request
Dec 13, 2024
* release 24.11.1-rc2 Signed-off-by: Andrew Kenworthy <[email protected]> * fix(helm): Add configuration options for the secret migration job (#536) * fix(helm): Add configuration options for the secret migration job * fix(helm): Default the tools image to 1.0.0-stackable24.11.0 --------- Signed-off-by: Andrew Kenworthy <[email protected]> Co-authored-by: Siegfried Weber <[email protected]>
I think it'd be useful to have a release note snippet for this. |
Release NotesSecret operatorHelm chart: The secret migration job required for upgrading from SDP 24.3 to 24.7, can now be omitted by setting the Helm value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
part of #477
Definition of Done Checklist
Author
Reviewer
Acceptance