Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a backend that requests Cert-Manager certificates #482

Merged
merged 30 commits into from
Sep 9, 2024
Merged

Add a backend that requests Cert-Manager certificates #482

merged 30 commits into from
Sep 9, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jul 23, 2024

Description

Fixes #474

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@nightkr

This comment was marked as resolved.

Sign in to view
@nightkr nightkr marked this pull request as ready for review August 1, 2024 14:45
@nightkr nightkr requested a review from a team August 1, 2024 14:48
@nightkr
Copy link
Member Author

nightkr commented Aug 6, 2024 •
edited by NickLarsenNZ
Loading

Voting comment for the CRD change.

@nightkr
Copy link
Member Author

nightkr commented Aug 9, 2024

It's been 3 days, CRD vote closed as accepted.

@nightkr nightkr requested review from sbernauer and a team August 9, 2024 10:11
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a lot of comments, and can't remember if there were any blockers so I will mark as approved.

I wish Github would make it easier to see the review summary before submitting

docs/modules/secret-operator/pages/cert-manager.adoc Show resolved Hide resolved
docs/modules/secret-operator/pages/secretclass.adoc Show resolved Hide resolved
rust/operator-binary/build.rs Show resolved Hide resolved
rust/operator-binary/src/backend/cert_manager.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/cert_manager.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/mod.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/backend/mod.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/crd.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/external_crd/cert_manager.rs Outdated Show resolved Hide resolved
tests/templates/kuttl/cert-manager-tls/consumer.yaml Outdated Show resolved Hide resolved
nightkr and others added 10 commits August 16, 2024 15:39
@nightkr nightkr requested a review from NickLarsenNZ August 28, 2024 10:30
NickLarsenNZ
NickLarsenNZ approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 3512603 Sep 9, 2024
31 checks passed
@nightkr nightkr deleted the feature/cert-manager branch September 9, 2024 11:33
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@sbernauer sbernauer Awaiting requested review from sbernauer

Assignees
No one assigned
Labels
customer-request release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Cert-Manager backend
4 participants
@nightkr @NickLarsenNZ @sbernauer @lfrancke