-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add peak velocity and peak acceleration #253
Conversation
Codecov Report
@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 89.82% 90.01% +0.18%
==========================================
Files 19 19
Lines 1573 1602 +29
==========================================
+ Hits 1413 1442 +29
Misses 160 160
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add definitions/descriptions of these two new statistics to docs/reference/statistics.rst?
Otherwise looks good!
…s.rst and fix a bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments, otherwise looks good!
(the CI is failing due to wxPython being down, not related to your changes)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I will merge the code to the main branch, thank you, Liam! |
mouse_positions:[[x0, y0], [x1, y1], ...]
mouse_times:[t0, t1, ...]
velocity:
[[Vx0,Vy0],[Vx1,Vy1], ...]
Vx0 = (x1-x0)/(t1-t0)
Vy0 = (y1-y0)/(t1-t0)
....
acceleration:
[[Ax0,Ay0],[Ax1,Ay1], ...]
Ax0 = (Vx1-Vx0)/(t1-t0)
Ay0 = (Vy1-Vy0)/(t1-t0)
....
peak velocity = max(velocity)
peak acceleration = max(acceleration)