Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trafficlight feedback frontend #214

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Dec 17, 2024

  • refactor the old feedback frontend from Add trafficlight feedback #183 into the latest available design from @Majapur1
  • add in a max number of answersessions that are displayed at once (currently 4) and make it navigable such that the history can be viewed in blocks of 4
  • try to fix styling to work better with mobile screen sizes
  • add better explanations in localization file
  • add a navigation button to the child card to get to the current feedback
  • fix bug in milestone indexing that would not allow to complete a milestone if answered with the lowest score.
  • add a second milestonegroup route specifically for milestonegroups of an answersession which is helpful for the feedback because it is displayed on a per answersession basis
  • fix a problem in the tests where the age bin a certain milestoneanswersession would fall into was dependent on the current date.
    fixes Implement traffic light feedback #155

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 14.61187% with 187 lines in your changes missing coverage. Please review.

Project coverage is 32.72%. Comparing base (de3f78d) to head (2717c8f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rontend/src/lib/components/ChildrenFeedback.svelte 0.00% 177 Missing and 1 partial ⚠️
...end/src/lib/components/ChildrenRegistration.svelte 0.00% 3 Missing ⚠️
frontend/src/lib/components/MilestoneGroup.svelte 0.00% 2 Missing ⚠️
frontend/src/lib/components/Milestone.svelte 0.00% 1 Missing ⚠️
...ontend/src/lib/components/MilestoneOverview.svelte 0.00% 1 Missing ⚠️
frontend/src/lib/stores/componentStore.ts 0.00% 1 Missing ⚠️
frontend/src/lib/stores/contentStore.svelte.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   34.60%   32.72%   -1.89%     
==========================================
  Files         109      111       +2     
  Lines        3742     4025     +283     
  Branches       94       96       +2     
==========================================
+ Hits         1295     1317      +22     
- Misses       2368     2627     +259     
- Partials       79       81       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaHaWo MaHaWo force-pushed the add-trafficlight-feedback-frontend branch from 8bf453a to 5f99e7a Compare December 18, 2024 10:04
@MaHaWo MaHaWo requested a review from lkeegan December 18, 2024 10:08
@MaHaWo MaHaWo self-assigned this Dec 20, 2024
@MaHaWo MaHaWo mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement traffic light feedback
2 participants