Refactor i18n implementation #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- main improvements
- all language texts can now be edited from the admin interface
- in frontend code we now have autocomplete for translation ids
- change in use
- i18n-svelte -> lib/i18n.svelte
- `$locale` -> `i18n.locale`
- `$locales` -> `i18n.locales`
- `$_('a.b')` -> `i18n.tr.a.b`
- to add a text, add the id to lib/translations.ts
- code changes
- remove i18n-svelte library
- remove locales/de.json: this is now included in the static folder of the deployed website, not part of the frontend source code anymore
- use camel case for all translation ids for consistency and to allow use without quotes
- de is now also editable in admin interface
- resolves #211
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 34.23% 1.49% -32.74%
==========================================
Files 109 83 -26
Lines 3783 2611 -1172
Branches 94 95 +1
==========================================
- Hits 1295 39 -1256
- Misses 2409 2493 +84
Partials 79 79 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$locale->i18n.locale$locales->i18n.locales$_('a.b')->i18n.tr.a.b