-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix visual elements on the frontpage #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lkeegan at that moment — yes. I met Sabina this week. She gave me additional comments and already approved the changes (including a new element) after reviewing them on my local machine. You can merge this step, and I'll create another branch for the new ones. |
Thanks - this can't be merged as is due to merge conflicts: Otherwise let me know and I can extract that single commit and merge it. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 34.60% 34.60%
=======================================
Files 109 109
Lines 3742 3742
Branches 94 94
=======================================
Hits 1295 1295
Misses 2368 2368
Partials 79 79 ☔ View full report in Codecov by Sentry. |
@lkeegan thanks for this lesson! Now I understand how it works and why some changes cannot be just merged into That was really helpful! |
889fe95