Skip to content

Commit

Permalink
Replace virtualenv by python3 -m venv, fix quantopian#48
Browse files Browse the repository at this point in the history
  • Loading branch information
squalou committed Oct 18, 2024
1 parent fdd7964 commit 7ee2b6f
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 6 deletions.
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@ PenguinDome also uses a bunch of Python packages, all of which are
deployed into a private virtualenv on the clients and server using
`pip` at install time.

`virtualenv` are created with native `python3 -m venv` tool now.
Existing `virtualenv` created previously with `virtualenv` continue
to work as-is.

The use of `netifaces` package in client plugins requires `pip`
to compile it, hence the requirement of ubuntu `python-dev` or
equivalent on *the client* side.

There's a nascent attempt in the `arch` subdirectory to build Pacman
client packages for Arch Linux, but these don't entirely work right
now, so for the time being, Arch clients use the same deployment
Expand Down
2 changes: 1 addition & 1 deletion client/arch-packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ git
lvm2
psmisc
python
python-virtualenv
python
systemd
tar
util-linux
Expand Down
2 changes: 1 addition & 1 deletion client/client-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ elif [ "$ID_LIKE" = "archlinux" -o "$ID" = "arch" ]; then
fi

if [ ! -d $venv ]; then
virtualenv -p python3 $venv
python3 -m venv $venv
fi

for dir in $(find $venv -name site-packages); do
Expand Down
3 changes: 2 additions & 1 deletion client/ubuntu-packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ systemd
tar
ubuntu-release-upgrader-core
update-notifier-common
virtualenv
python3-venv
python3-dev
wireless-tools
2 changes: 1 addition & 1 deletion server/arch-packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ gnupg
https://aur.archlinux.org/libgfshare.git
openssl
python
python-virtualenv
python
systemd
tar
2 changes: 1 addition & 1 deletion server/server-setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ elif [ "$ID_LIKE" = "archlinux" ]; then
fi

if [ ! -d $venv ]; then
virtualenv -p python3 $venv
python3 -m venv $venv
fi

for dir in $(find $venv -name site-packages); do
Expand Down
3 changes: 2 additions & 1 deletion server/ubuntu-packages.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ openssl
python3
systemd
tar
virtualenv
python3-venv
python3-dev

0 comments on commit 7ee2b6f

Please sign in to comment.