This repository has been archived by the owner on Jun 18, 2023. It is now read-only.
Code formatting with spotless (prettier) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonback
force-pushed
the
feature/code-formatting
branch
from
2cbefac to
04ba277
Compare
✅ Deploy Preview for mellow-manatee-3041fb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits (+ files) show the spotless configuration.
The formatting uses prettier, while respecting the custom
.editorconfigconfiguration.The third commit showcases the target formatting.
To avoid merge conflicts with other PRs, this PR should probably merged last and/or the
spotlessApplygradle task should be run to fix outstanding formatting issues.Feel free to suggest other formatters.
I view this as a start for a discussion to apply some formatter to springwolf-core as well.
Spotless (+ gradle plugin): https://github.com/diffplug/spotless
Relates to: springwolf/springwolf-core#93