Make Saml2AuthenticationToken Serializable #16287
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
There was a problem hiding this comment.
Thanks, @ngocnhan-tran1996, for the PR!
In addition to my inline feedback, will you please add Closes gh-16286 to the end of your commit message?
...org/springframework/security/saml2/provider/service/registration/AssertingPartyMetadata.java
Show resolved
Hide resolved
| @@ -309,6 +311,7 @@ class SpringSecurityCoreVersionSerializableTests { | |||
| (r) -> TestSaml2PostAuthenticationRequests.create()); | |||
| generatorByClassName.put(Saml2RedirectAuthenticationRequest.class, | |||
| (r) -> TestSaml2RedirectAuthenticationRequests.create()); | |||
| generatorByClassName.put(RelyingPartyRegistration.class, (r) -> TestRelyingPartyRegistrations.full().build()); | |||
There was a problem hiding this comment.
Please run the serializeCurrentVersionClasses test so that the appropriate .serialized file gets created. You can see #16276 for more details.
jzheaux
added
type: bug
|
Thanks for your review. I will rebase commit into below message if my PR does not have any changes. |
|
Please review and tell me if I missunderstood |
There was a problem hiding this comment.
Thanks for the updates, @ngocnhan-tran1996. This is close. I've left feedback inline.
| public final class Saml2X509Credential { | ||
| public final class Saml2X509Credential implements Serializable { | ||
|
|
||
| private static final long serialVersionUID = SpringSecurityCoreVersion.SERIAL_VERSION_UID; |
There was a problem hiding this comment.
Since this didn't have a serial version UID declared before 6.3 (when Spring Security started ensuring backward compatibility with Java serialization), it needs to be the JVM-calculated value.
There was a problem hiding this comment.
This is the same for the other classes as well
ngocnhan-tran1996
force-pushed
the
gh-16286
branch
2 times, most recently
from
230f662 to
ee25efa
Compare
Closes spring-projectsgh-16286 Generate file serialized Generate file serialized
ngocnhan-tran1996
force-pushed
the
gh-16286
branch
from
be97a2b to
bbc8e69
Compare
Closes gh-16286