Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception message if unable to select a bean to wrap for @MockitoSpyBean #33965

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 26, 2024

See GH-33935

@sbrannen
Copy link
Member

sbrannen commented Dec 2, 2024

Thanks for the PR, @quaff. 👍

However, if we're going to do this, we shouldn't do it only for wrapping. Instead, we should improve the diagnostics for all such cases.

I'm therefore closing as:

@quaff, if you want to submit a PR for #34004, feel free, and I can assist you with addressing the topic consistently for all use cases. Or... I can pick it up. I'll leave it up to you. 😉

@sbrannen sbrannen closed this Dec 2, 2024
@sbrannen sbrannen added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 2, 2024
@quaff
Copy link
Contributor Author

quaff commented Dec 3, 2024

@quaff, if you want to submit a PR for #34004, feel free, and I can assist you with addressing the topic consistently for all use cases. Or... I can pick it up. I'll leave it up to you. 😉

Yes, I'd like to submit a PR, please review #34006 @sbrannen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants