Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Javadoc @since tag from MapAccessor default constructor #33659

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Oct 6, 2024

Overview

This PR removes Javadoc @since tag from MapAccessor() as it seems to have been added accidentally.

Related Issues

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 6, 2024
@sbrannen sbrannen changed the title Remove Javadoc since from MapAccessor() Remove Javadoc @since tag from MapAccessor default constructor Oct 6, 2024
@sbrannen sbrannen self-assigned this Oct 6, 2024
@sbrannen sbrannen added type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 6, 2024
@sbrannen sbrannen added this to the 6.2.0-RC2 milestone Oct 6, 2024
@sbrannen sbrannen merged commit 1016743 into spring-projects:main Oct 6, 2024
6 checks passed
@sbrannen
Copy link
Member

sbrannen commented Oct 6, 2024

Hi @izeye,

Technically speaking, that explicit default constructor was introduced in 6.2; however, you're right: it always had an implicit default constructor. So, the @since tag can indeed be misinterpreted, and I've merged your PR into main to avoid confusion.

Thanks

@izeye izeye deleted the polish-gh-33222 branch October 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants