Improve wording in Javadoc for @Autowired
#31235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
changed the title
@Autowired
sbrannen
approved these changes
Sep 14, 2023
| @@ -30,7 +30,7 @@ | |||
| * <h3>Autowired Constructors</h3> | |||
| * <p>Only one constructor of any given bean class may declare this annotation with the | |||
| * {@link #required} attribute set to {@code true}, indicating <i>the</i> constructor | |||
| * to autowire when used as a Spring bean. Furthermore, if the {@code required} | |||
| * to be autowired when used as a Spring bean. Furthermore, if the {@code required} | |||
There was a problem hiding this comment.
It's actually grammatically correct as-is; however, the proposed change may be easier to understand for most readers. So we'll merge the PR to improve the wording, and I've updated the title accordingly.
There was a problem hiding this comment.
Thanks! It's my first-ever GitHub contribution.
|
This has been merged into Thanks, and congratulations on your first contribution to the Spring Framework! 👍 |
snicoll
removed
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.