-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The guide as it exists has a few fundamental problems that prevent implementing a CI build system: The guide template was checked into the repository, which is what the Jenkins CI system was attempting to run. The guide contained template code at the root level that had dependencies and a 'hello world' example that was not relevant to this guide. The tests inside of the bookstore and reading folders were not executed and were not passing The bookstore and reading applications did not contain the gradle or maven wrappers The initial folder did not have a base main class instance which caused both bookstore and reading builds to fail To remedy these problems: Remove the unused template code in the base directory Simplify the existing tests, largely by removing functionality out of scope for the guide instructions Copy instances of maven and gradle wrappers to all application directories Implemented a base class for initial/bookstore and initial/reading Removed Jenkins CI files Added GitHub Actions CI file
- Loading branch information
1 parent
db295b3
commit bf0ed83
Showing
61 changed files
with
2,618 additions
and
1,413 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
name: CI Build | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
build: | ||
name: Build Main Branch | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout source code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up JDK 17 | ||
uses: actions/setup-java@v4 | ||
with: | ||
java-version: '17' | ||
distribution: 'temurin' | ||
cache: maven | ||
|
||
- name: Build Initial Reading with Maven | ||
working-directory: ./initial/reading | ||
run: ./mvnw --batch-mode clean package | ||
|
||
- name: Build Initial Reading with Gradle | ||
working-directory: ./initial/reading | ||
run: ./gradlew build | ||
|
||
- name: Build Initial Bookstore with Maven | ||
working-directory: ./initial/bookstore | ||
run: ./mvnw --batch-mode clean package | ||
|
||
- name: Build Initial Bookstore with Gradle | ||
working-directory: ./initial/bookstore | ||
run: ./gradlew build | ||
|
||
|
||
- name: Build Complete Reading with Maven | ||
working-directory: ./complete/reading | ||
run: ./mvnw --batch-mode clean package | ||
|
||
- name: Build Complete Reading with Gradle | ||
working-directory: ./complete/reading | ||
run: ./gradlew build | ||
|
||
- name: Build Complete Bookstore with Maven | ||
working-directory: ./complete/bookstore | ||
run: ./mvnw --batch-mode clean package | ||
|
||
- name: Build Complete Bookstore with Gradle | ||
working-directory: ./complete/bookstore | ||
run: ./gradlew build |
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,19 @@ | ||
distributionUrl=https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.3.3/apache-maven-3.3.3-bin.zip | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
wrapperVersion=3.3.2 | ||
distributionType=only-script | ||
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip |
Binary file not shown.
4 changes: 3 additions & 1 deletion
4
.../gradle/wrapper/gradle-wrapper.properties → .../gradle/wrapper/gradle-wrapper.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip | ||
networkTimeout=10000 | ||
validateDistributionUrl=true | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.