Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on adding support for collections to
react-notion
, I've come across some high level issues./table
to/collection
.block.value.collection.types
toblock.value.collection.views
because it makes a lot more sense.Beyond this PR,
/collection
would ideally not take in apageId
but rather acollectionId
andcollectionViewId
since the abstraction of using a page to fetch a collection doesn't really work once you start having more complicated collections and views. This will also be necessary to fetch the data for a specific collection view dynamically since I don't think it makes sense for the initial page content to contain all the data for all collections and their corresponding views.So I propose the following going forwards:
/page
will only contain data for each collection's default view./collection
to fetch that view's data.